Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update query to show root_account user status as info. #286

Merged
merged 3 commits into from
Sep 23, 2021

Conversation

rajlearner17
Copy link
Contributor

Checklist

  • Issue(s) linked

@rajlearner17 rajlearner17 marked this pull request as draft September 21, 2021 17:52
@rajlearner17
Copy link
Contributor Author

rajlearner17 commented Sep 21, 2021

The earlier query does not need any major change, we just made root_account status as info, it will have all required validation as applicable for other users. This is behind turbot/steampipe-plugin-aws#662

@rajlearner17 rajlearner17 self-assigned this Sep 21, 2021
@rajlearner17 rajlearner17 linked an issue Sep 23, 2021 that may be closed by this pull request
@rajlearner17 rajlearner17 marked this pull request as ready for review September 23, 2021 10:44
@@ -2,6 +2,9 @@ select
-- Required Columns
user_arn as resource,
case
--root_account will have always password associated even though AWS credential report returns 'not_supported' for password_enabled
when user_name = '<root_account>'
then 'info'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add them into a single line

@@ -2,6 +2,8 @@ select
-- Required Columns
user_arn as resource,
case
when user_name = '<root_account>'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add them into a single line

@misraved misraved merged commit 31aa1ed into release/v0.14 Sep 23, 2021
@misraved misraved deleted the root-acct-#276 branch September 23, 2021 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conflict with cis_v140_1_7 and cis_v140_1_12
3 participants