Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update autoscaling_group_with_lb_use_healthcheck. Closes #24 #30

Merged
merged 3 commits into from
May 25, 2021

Conversation

khushboo9024
Copy link
Contributor

@khushboo9024 khushboo9024 commented May 24, 2021

Checklist

  • Issue(s) linked

@khushboo9024 khushboo9024 self-assigned this May 24, 2021
@khushboo9024 khushboo9024 linked an issue May 24, 2021 that may be closed by this pull request
@cbruno10 cbruno10 changed the base branch from main to release/v0.2 May 24, 2021 12:35
@cbruno10 cbruno10 self-requested a review May 24, 2021 12:35
Copy link
Contributor

@cbruno10 cbruno10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comment

end reason,
end as status,
case
when load_balancer_names is null and target_group_arns is null then title || ' not associated with ELBs.'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
when load_balancer_names is null and target_group_arns is null then title || ' not associated with ELBs.'
when load_balancer_names is null and target_group_arns is null then title || ' not associated with ELBs.'

@cbruno10 cbruno10 merged commit 46c36f0 into release/v0.2 May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update autoscaling_group_with_lb_use_healthcheck
2 participants