Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new controls for PCI DSS in Security Hub - PCI.OpenSearch.1 & PCI.OpenSearch.2 Closes #383 #385

Merged
merged 1 commit into from
May 11, 2022

Conversation

khushboo9024
Copy link
Contributor

@khushboo9024 khushboo9024 commented May 11, 2022

Checklist

  • Issue(s) linked
    image
    image

@khushboo9024 khushboo9024 self-assigned this May 11, 2022
Copy link
Contributor

@rajlearner17 rajlearner17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

else 'ok'
end status,
case
when vpc_options ->> 'VPCId' is null then title || ' not in VPC.'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khushboo9024 if we can include checking the below statements

You should ensure that Amazon OpenSearch domains are not attached to public subnets. See [Resource-based policies](https://docs.aws.amazon.com/opensearch-service/latest/developerguide/ac.html#ac-types-resource) in the Amazon OpenSearch Service Developer Guide.

Reference

It may also first check vpc_subnet_auto_assign_public_ip_disabled.sql, where we check map_public_ip_on_launch.

Additionally, we can filter the subnet_id from https://hub.steampipe.io/plugins/turbot/aws/tables/aws_vpc_route_table#subnet-and-gateways-associated-with-the-route-table and match if it's associated with any IGW.

This will be a strict check

@rajlearner17 rajlearner17 merged commit 991135e into release/v0.32 May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants