Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the query name to use ebs_volume_unused instead of ebs_volume_unsued closes #411 #412

Merged
merged 1 commit into from
Jun 13, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions conformance_pack/ebs.sp
Original file line number Diff line number Diff line change
Expand Up @@ -94,10 +94,10 @@ control "ebs_volume_protected_by_backup_plan" {
})
}

control "ebs_volume_unsued" {
control "ebs_volume_unused" {
title = "EBS volumes should be attached to EC2 instance"
description = "Checks if EBS volumes are attached to EC2 instance."
sql = query.ebs_volume_unsued.sql
sql = query.ebs_volume_unused.sql

tags = merge(local.conformance_pack_ebs_common_tags, {
fedramp_low_rev_4 = "true"
Expand Down
2 changes: 1 addition & 1 deletion fedramp_low_rev_4/cm.sp
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ benchmark "fedramp_low_rev_4_cm_2" {
control.autoscaling_launch_config_public_ip_disabled,
control.dms_replication_instance_not_publicly_accessible,
control.ebs_snapshot_not_publicly_restorable,
control.ebs_volume_unsued,
control.ebs_volume_unused,
control.ec2_instance_in_vpc,
control.ec2_instance_not_publicly_accessible,
control.ec2_instance_ssm_managed,
Expand Down
2 changes: 1 addition & 1 deletion fedramp_moderate_rev_4/cm.sp
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ benchmark "fedramp_moderate_rev_4_cm_2" {
control.dms_replication_instance_not_publicly_accessible,
control.ebs_attached_volume_delete_on_termination_enabled,
control.ebs_snapshot_not_publicly_restorable,
control.ebs_volume_unsued,
control.ebs_volume_unused,
control.ec2_instance_in_vpc,
control.ec2_instance_not_publicly_accessible,
control.ec2_instance_ssm_managed,
Expand Down
2 changes: 1 addition & 1 deletion fedramp_moderate_rev_4/sc.sp
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ benchmark "fedramp_moderate_rev_4_sc_4" {
children = [
control.dms_replication_instance_not_publicly_accessible,
control.ebs_snapshot_not_publicly_restorable,
control.ebs_volume_unsued,
control.ebs_volume_unused,
control.lambda_function_restrict_public_access,
control.rds_db_instance_prohibit_public_access,
control.rds_db_snapshot_prohibit_public_access,
Expand Down
16 changes: 8 additions & 8 deletions nist_800_53_rev_5/cm.sp
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ benchmark "nist_800_53_rev_5_cm_2_a" {
title = "CM-2(a)"
description = "Develop, document, and maintain under configuration control, a current baseline configuration of the system."
children = [
control.ebs_volume_unsued,
control.ebs_volume_unused,
control.ec2_instance_ssm_managed,
control.ec2_stopped_instance_30_days,
control.elb_application_lb_deletion_protection_enabled,
Expand All @@ -50,7 +50,7 @@ benchmark "nist_800_53_rev_5_cm_2_b" {
benchmark.nist_800_53_rev_5_cm_2_b_2,
benchmark.nist_800_53_rev_5_cm_2_b_3,
control.account_part_of_organizations,
control.ebs_volume_unsued,
control.ebs_volume_unused,
control.ec2_instance_ssm_managed,
control.ec2_stopped_instance_30_days,
control.redshift_cluster_maintenance_settings_check,
Expand All @@ -65,7 +65,7 @@ benchmark "nist_800_53_rev_5_cm_2_b_1" {
description = "Review and update the baseline configuration of the system: 1. [Assignment: organization-defined frequency]."
children = [
control.account_part_of_organizations,
control.ebs_volume_unsued,
control.ebs_volume_unused,
control.ec2_instance_ssm_managed,
control.ec2_stopped_instance_30_days,
control.redshift_cluster_maintenance_settings_check,
Expand All @@ -80,7 +80,7 @@ benchmark "nist_800_53_rev_5_cm_2_b_2" {
description = "Review and update the baseline configuration of the system: 2. When required due to [Assignment: organization-defined circumstances]."
children = [
control.account_part_of_organizations,
control.ebs_volume_unsued,
control.ebs_volume_unused,
control.ec2_instance_ssm_managed,
control.ec2_stopped_instance_30_days,
control.redshift_cluster_maintenance_settings_check,
Expand All @@ -95,7 +95,7 @@ benchmark "nist_800_53_rev_5_cm_2_b_3" {
description = "Review and update the baseline configuration of the system: 3 When system components are installed or upgraded."
children = [
control.account_part_of_organizations,
control.ebs_volume_unsued,
control.ebs_volume_unused,
control.ec2_instance_ssm_managed,
control.ec2_stopped_instance_30_days,
control.redshift_cluster_maintenance_settings_check,
Expand All @@ -109,7 +109,7 @@ benchmark "nist_800_53_rev_5_cm_2_2" {
title = "CM-2(2) Automation Support For AccuracyY And Currency"
description = "Maintain the currency, completeness, accuracy, and availability of the baseline configuration of the system using [Assignment: organization-defined automated mechanisms]."
children = [
control.ebs_volume_unsued,
control.ebs_volume_unused,
control.ec2_instance_ssm_managed,
control.ec2_stopped_instance_30_days,
control.elb_application_lb_deletion_protection_enabled,
Expand Down Expand Up @@ -147,7 +147,7 @@ benchmark "nist_800_53_rev_5_cm_3_3" {
description = "Implement changes to the current system baseline and deploy the updated baseline across the installed base using [Assignment: organization-defined automated mechanisms]."
children = [
control.account_part_of_organizations,
control.ebs_volume_unsued,
control.ebs_volume_unused,
control.ec2_instance_ssm_managed,
control.ec2_stopped_instance_30_days,
control.redshift_cluster_maintenance_settings_check,
Expand Down Expand Up @@ -445,7 +445,7 @@ benchmark "nist_800_53_rev_5_cm_8_6" {
title = "CM-8(6) Assessed Configurations And Approved Deviations"
description = "Include assessed component configurations and any approved deviations to current deployed configurations in the system component inventory."
children = [
control.ebs_volume_unsued,
control.ebs_volume_unused,
control.ec2_instance_ssm_managed,
control.ec2_stopped_instance_30_days,
control.elb_application_lb_deletion_protection_enabled,
Expand Down
File renamed without changes.