Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FSBP AutoScaling.6 Closes #472 #488

Merged
merged 2 commits into from
Aug 26, 2022
Merged

Add FSBP AutoScaling.6 Closes #472 #488

merged 2 commits into from
Aug 26, 2022

Conversation

vkumbha
Copy link
Contributor

@vkumbha vkumbha commented Aug 23, 2022

Checklist

  • Issue(s) linked

@vkumbha vkumbha self-assigned this Aug 23, 2022
@vkumbha vkumbha linked an issue Aug 23, 2022 that may be closed by this pull request
Add FSBP AutoScaling.6 #472
Closed
@misraved misraved changed the base branch from main to release/v0.46 August 26, 2022 05:26
misraved
misraved reviewed Aug 26, 2022
View reviewed changes
query/autoscaling/autoscaling_use_multiple_instance_types_in_multiple_az.sql
Comment on lines +31 to +32
when b.distinct_instance_types > 1 then title || ' uses ' || b.distinct_instance_types || ' instance types.'
else title || ' does not use multiple instance types.'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
when b.distinct_instance_types > 1 then title || ' uses ' || b.distinct_instance_types || ' instance types.'
else title || ' does not use multiple instance types.'
title || ' uses ' || b.distinct_instance_types || ' instance types.'

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

b.distinct_instance_types will be null for instances which do not have the autoscaling override option enabled.

misraved
misraved reviewed Aug 26, 2022
View reviewed changes
Copy link
Contributor

@misraved misraved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion to use a single reason to provide information on how many instance types are being used.

@misraved misraved merged commit 725f80a into release/v0.46 Aug 26, 2022
@misraved misraved deleted the 472-add-fsbp-autoscaling6 branch August 26, 2022 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misraved misraved misraved approved these changes

@rajlearner17 rajlearner17 Awaiting requested review from rajlearner17

Assignees

@vkumbha vkumbha

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add FSBP AutoScaling.6
2 participants
@vkumbha @misraved