Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add [S3.12] S3 access control lists (ACLs) should not be used to manage user access to buckets. Closes #363 #489

Merged
merged 4 commits into from
Sep 12, 2022
Merged

Add [S3.12] S3 access control lists (ACLs) should not be used to manage user access to buckets. Closes #363 #489

merged 4 commits into from
Sep 12, 2022

Conversation

vkumbha
Copy link
Contributor

@vkumbha vkumbha commented Aug 24, 2022

Checklist

  • Issue(s) linked

@vkumbha vkumbha self-assigned this Aug 24, 2022
@vkumbha vkumbha linked an issue Aug 24, 2022 that may be closed by this pull request
Add [S3.12] S3 access control lists (ACLs) should not be used to manage user access to buckets #363
Closed
cbruno10
cbruno10 requested changes Aug 24, 2022
View reviewed changes
Copy link
Contributor

@cbruno10 cbruno10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vkumbha Please see review, thanks!

foundational_security/s3.sp Show resolved Hide resolved
@vkumbha vkumbha requested a review from cbruno10 August 24, 2022 15:21
@misraved misraved changed the base branch from main to release/v0.46 August 26, 2022 05:26
misraved
misraved reviewed Aug 29, 2022
View reviewed changes
Copy link
Contributor

@misraved misraved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make changes as per the suggestions.

Base automatically changed from release/v0.46 to main August 30, 2022 23:16
@cbruno10 cbruno10 changed the base branch from main to release/v0.47 September 12, 2022 13:46
@cbruno10 cbruno10 merged commit 7f213ea into release/v0.47 Sep 12, 2022
@cbruno10 cbruno10 deleted the 363-add-s312-s3-access-control-lists-acls-should-not-be-used-to-manage-user-access-to-buckets branch September 12, 2022 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misraved misraved misraved left review comments

@cbruno10 cbruno10 cbruno10 approved these changes

@rajlearner17 rajlearner17 rajlearner17 approved these changes

Assignees

@vkumbha vkumbha

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add [S3.12] S3 access control lists (ACLs) should not be used to manage user access to buckets
4 participants
@vkumbha @cbruno10 @rajlearner17 @misraved