ebs_attached_volume_encryption_enabled should validate all EBS volume without where condition Closes #503 #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… without where condition Closes #503
cbruno10
requested changes
Sep 23, 2022
| @@ -2,17 +2,17 @@ select | |||
| -- Required Columns | |||
| arn as resource, | |||
| case | |||
| when state != 'in-use' then 'info' | |||
There was a problem hiding this comment.
Suggested change
| when state != 'in-use' then 'info' | |
| when state != 'in-use' then 'skip' |
If we're not evaluating them, should it be in skip state instead? What does the original query/config rule say about evaluating unattached volumes (or doesn't say)?
There was a problem hiding this comment.
@cbruno10 this is what it says below; non-attached ones we can skip
This control checks whether the EBS volumes that are in an attached state are encrypted. To pass this check, EBS volumes must be in use and encrypted. If the EBS volume is not attached, then it is not subject to this check.
misraved
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist