Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated documentation as per query conditions and spelling fixes #508

Merged
merged 8 commits into from
Oct 5, 2022
Merged

Updated documentation as per query conditions and spelling fixes #508

merged 8 commits into from
Oct 5, 2022

Conversation

akumar-99
Copy link
Contributor

Checklist

  • Issue(s) linked

@rajlearner17
Copy link
Contributor

@akumar-99 Appreciate your feedback and the PR 👍

Some of the content is from CIS doc directly as we don't change them, or we might have missed appropriate updates. We will carefully review it and bring it on. Again thanks for using Steampipe.

cbruno10
cbruno10 requested changes Oct 3, 2022
View reviewed changes
Copy link
Contributor

@cbruno10 cbruno10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akumar-99 Thanks again for raising this PR!

I've commented on a few files with proposals to revert some of the changes you've made. Instead of retroactively updating all CIS docs, we choose instead to look forward to future CIS versions, like v1.6.0.

I didn't comment on every instance where I would suggest reverting, but can you please have a look at my comments and apply those across the PR? The general typo fixes we do definitely want to merge in though.

Thanks!

cis_v130/docs/cis_v130_5_1.md Outdated Show resolved Hide resolved
cis_v130/docs/cis_v130_5_2.md Outdated Show resolved Hide resolved
cis_v130/section_5.sp Outdated Show resolved Hide resolved
cis_v130/section_5.sp Outdated Show resolved Hide resolved
cis_v150/docs/cis_v150_5_3.md Outdated Show resolved Hide resolved
akumar-99 and others added 5 commits October 4, 2022 01:40
@akumar-99 @cbruno10
Update cis_v130/docs/cis_v130_5_1.md
7201a15 
Co-authored-by: cbruno10 <cody@turbot.com>
@akumar-99 @cbruno10
Update cis_v130/section_5.sp
16984c8 
Co-authored-by: cbruno10 <cody@turbot.com>
@akumar-99 @cbruno10
Update cis_v130/docs/cis_v130_5_2.md
5e636c8 
Co-authored-by: cbruno10 <cody@turbot.com>
@akumar-99 @cbruno10
Update cis_v130/section_5.sp
7ef8526 
Co-authored-by: cbruno10 <cody@turbot.com>
@akumar-99
revert changes
a038535
cbruno10
cbruno10 requested changes Oct 5, 2022
View reviewed changes
Copy link
Contributor

@cbruno10 cbruno10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akumar-99 Please see additional comment, thanks!

cis_v140/docs/cis_v140_5_2.md Outdated Show resolved Hide resolved
@cbruno10 cbruno10 merged commit 6960022 into turbot:release/v0.49 Oct 5, 2022
@cbruno10
Copy link
Contributor

cbruno10 commented Oct 5, 2022

Thanks @akumar-99 for catching and fixing these typos!

@akumar-99 akumar-99 deleted the patch-doc-fixes branch October 5, 2022 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbruno10 cbruno10 cbruno10 approved these changes

@khushboo9024 khushboo9024 Awaiting requested review from khushboo9024

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akumar-99 @rajlearner17 @cbruno10