Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Control For Foundational Security Autoscaling 9 #529

Merged
merged 3 commits into from
Nov 22, 2022
Merged

Add Control For Foundational Security Autoscaling 9 #529

merged 3 commits into from
Nov 22, 2022

Conversation

Priyanka-Chatterjee-2000
Copy link
Contributor

Checklist

  • Issue(s) linked

@Priyanka-Chatterjee-2000 Priyanka-Chatterjee-2000 linked an issue Nov 21, 2022 that may be closed by this pull request
Add new FSBP [AutoScaling.9] control #526
Closed
@Priyanka-Chatterjee-2000 Priyanka-Chatterjee-2000 marked this pull request as ready for review November 21, 2022 15:05
misraved
misraved reviewed Nov 22, 2022
View reviewed changes
Copy link
Contributor

@misraved misraved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at the review comments. Thanks!!

query/autoscaling/autoscaling_group_uses_ec2_launch_template.sql Outdated
else 'alarm'
end as status,
case
when launch_template_id is not null then title || 'created from an EC2 launch template.'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
when launch_template_id is not null then title || 'created from an EC2 launch template.'
when launch_template_id is not null then title || ' created from an EC2 launch template.'

query/autoscaling/autoscaling_group_uses_ec2_launch_template.sql Outdated
end as status,
case
when launch_template_id is not null then title || 'created from an EC2 launch template.'
else title || 'not created from an EC2 launch template.'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
else title || 'not created from an EC2 launch template.'
else title || ' not created from an EC2 launch template.'

rajlearner17
rajlearner17 approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@rajlearner17 rajlearner17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after testing

@misraved misraved merged commit a9fb911 into release/v0.54 Nov 22, 2022
@misraved misraved deleted the foundational_security_autoscaling_9 branch November 22, 2022 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misraved misraved misraved approved these changes

@rajlearner17 rajlearner17 rajlearner17 approved these changes

Assignees

@Priyanka-Chatterjee-2000 Priyanka-Chatterjee-2000

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add new FSBP [AutoScaling.9] control
3 participants
@Priyanka-Chatterjee-2000 @rajlearner17 @misraved