Add Audit Manager > PCI DSS v3.2.1 controls #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/steampipe-mod-aws-compliance into new-other-checks-query-pc
…/steampipe-mod-aws-compliance into new-other-checks-query-pc
cbruno10
changed the title
rajlearner17
changed the title
rajlearner17
approved these changes
Mar 29, 2023
misraved
reviewed
Mar 30, 2023
There was a problem hiding this comment.
@Priyanka-Chatterjee-2000 please take a look at the review comments. Thanks!!
Also could you please make updates to README and docs/index.md files to highighting the new benchmark?
| when predicates is null or jsonb_array_length(predicates) = 0 then title || ' has no attached conditions.' | ||
| else title || ' has attached conditions.' | ||
| end as reason | ||
| ${local.common_dimensions_sql} |
There was a problem hiding this comment.
Does the resource support tags?
There was a problem hiding this comment.
No the resource does not support tags
conformance_pack/waf.sp
Outdated
| } | ||
|
|
||
| control "waf_web_acl_logging_enabled" { | ||
| title = "Logging should be enabled on on AWS Web Application Firewall (WAF) classic global web ACLs" |
There was a problem hiding this comment.
Suggested change
| title = "Logging should be enabled on on AWS Web Application Firewall (WAF) classic global web ACLs" | |
| title = "WAF web ACL logging should be enabled" |
pci_dss_v321/requirement_1.sp
Outdated
| ] | ||
|
|
||
| tags = merge(local.pci_dss_v321_requirement_1_common_tags, { | ||
| pci_dss_v321_item_id = "1.3.3" |
There was a problem hiding this comment.
Suggested change
| pci_dss_v321_item_id = "1.3.3" | |
| pci_dss_v321_item_id = "1.3.5" |
misraved
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.