Add new FSBP [EC2.25] control Closes #543 #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| else t.title || ' not publicly accessible.' | ||
| end as reason, | ||
| -- Additional Dimensions | ||
| t.region, |
There was a problem hiding this comment.
@khushboo9024 once the tag 7 dimension is released, we need to update this with common dimension & tags
misraved
reviewed
Mar 22, 2023
There was a problem hiding this comment.
@khushboo9024 Could you please take a look at the suggested changes?
conformance_pack/ec2.sp
Outdated
| aws_ec2_instance | ||
| ) | ||
| select | ||
| -- Required Columns |
There was a problem hiding this comment.
Suggested change
| -- Required Columns |
conformance_pack/ec2.sp
Outdated
| when t.launch_template_id in ( select public_launch_template_id from public_launch_templates ) then t.title || ' publicly accessible.' | ||
| else t.title || ' not publicly accessible.' | ||
| end as reason | ||
| -- Additional Dimensions |
There was a problem hiding this comment.
Suggested change
| -- Additional Dimensions |
misraved
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.