Add common and tag dimensions across compliance queries closes #33 #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@khushboo9024 can you pls check this |
rajlearner17
approved these changes
May 15, 2023
misraved
reviewed
May 16, 2023
There was a problem hiding this comment.
@khushboo9024 please take a look at the review comments. Thanks!!
Comment on lines
+22
to
+25
| description = "A list of tags to add as dimensions to each control." | ||
| # A list of tag names to include as dimensions for resources that support | ||
| # tags (e.g. "Owner", "Environment"). Default to empty since tag names are | ||
| # a personal choice - for commonly used tag names see |
There was a problem hiding this comment.
Suggested change
| description = "A list of tags to add as dimensions to each control." | |
| # A list of tag names to include as dimensions for resources that support | |
| # tags (e.g. "Owner", "Environment"). Default to empty since tag names are | |
| # a personal choice - for commonly used tag names see | |
| description = "A list of tags to add as dimensions to each control." | |
| # A list of tag names to include as dimensions for resources that support | |
| # tags (e.g. "Owner", "Environment"). Default to empty since tag names are | |
| # a personal choice. |
There was a problem hiding this comment.
I think we could add https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/ as a document reference for commonly used tags.
mod.sp
Outdated
| common_dimensions_namespace_sql = replace(local.common_dimensions_qualifier_namespace_sql, "__QUALIFIER__", "") | ||
| common_dimensions_non_namespace_sql = replace(local.common_dimensions_non_namespace_qualifier_sql, "__QUALIFIER__", "") | ||
| tag_dimensions_sql = replace(local.tag_dimensions_qualifier_sql, "__QUALIFIER__", "") | ||
|
|
| ``` | ||
|
|
||
| ```shell | ||
| steampipe check benchmark.cis_kube_v120 --var 'tag_dimensions=["Environment", "Owner"]' |
There was a problem hiding this comment.
Instead of Environment and Owner, could we add different tag examples in the doc files?
|
Tested the 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist