Kubernetes CIS v1.7.0 #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cis_v170/section_5.sp
Outdated
| cis_section_id = "5.1" | ||
| }) | ||
|
|
||
| cis_v170_5_2_common_tags = merge(local.cis_v170_5_common_tags, { |
There was a problem hiding this comment.
@karanpopat, should this section be removed, as we are not making it part of this CIS version?
| benchmark "cis_v170" { | ||
| title = "CIS v1.7.0" | ||
| documentation = file("./cis_v170/docs/cis_v170_overview.md") | ||
| children = [ |
There was a problem hiding this comment.
Add
description = "CIS v1.7.0 benchmark provides prescriptive guidance for establishing a secure configuration posture for Kubernetes 1.25."
rajlearner17
approved these changes
May 15, 2023
misraved
reviewed
May 17, 2023
There was a problem hiding this comment.
@karanpopat please take a look at the minor review comments.
Also, please update the doc files to mention about the new CIS benchmark.
madhushreeray30
requested changes
May 17, 2023
misraved
reviewed
May 17, 2023
misraved
reviewed
May 18, 2023
misraved
approved these changes
May 18, 2023
misraved
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist