Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new other checks #64

Merged
merged 49 commits into from
Sep 29, 2023
Merged

Add new other checks #64

merged 49 commits into from
Sep 29, 2023

Conversation

karanpopat
Copy link
Contributor

Checklist

  • Issue(s) linked

khushboo9024 and others added 27 commits September 25, 2023 13:11
@khushboo9024
added new controls
f422898
@khushboo9024
add new query
98d4cdf
@khushboo9024
added new controls
e59152b
@karanpopat
Check for NamespaceLifecycle
0d83bea
@karanpopat
Merge branch 'add-new-other-checks-kp' into add-new-other-checks
48d297d
@Priyanka-Chatterjee-2000
Add queries and controls
6c53033
@karanpopat
Check for NamespaceLifecycle
58fbad0
@Priyanka-Chatterjee-2000
Resolve conflicts
f0d03f5
@Priyanka-Chatterjee-2000
Merge branch 'add-new-other-checks' of https://github.com/turbot/stea…
f05fd2b 
…mpipe-mod-kubernetes-compliance into add-new-other-checks
@Priyanka-Chatterjee-2000
Update query, control name and description from etcd_certfile_and_key…
c3ad738 
…file_configured to kube_apiserver_etcd_certfile_and_keyfile_configured
@karanpopat
Check for NodeRestriction
23beb56
@karanpopat
Add commit blocks
9ecc68c
@karanpopat
Check for PodSecurityPolicy
aae678b
@Priyanka-Chatterjee-2000
Add queries and controls
1923a84
@karanpopat
Check for kube-apiserver profiling disabled
6f58da0
@Priyanka-Chatterjee-2000
Resolve Merge conflicts for branch 'add-new-other-checks' of https://…
369a7fc 
…github.com/turbot/steampipe-mod-kubernetes-compliance into add-new-other-checks
@Priyanka-Chatterjee-2000
Merge branch 'add-new-other-checks' of https://github.com/turbot/stea…
a378c04 
…mpipe-mod-kubernetes-compliance into add-new-other-checks
@karanpopat
Check for kube-apiserver secure port not set to 0
52ff7e1
@Priyanka-Chatterjee-2000
Update query,control name and description from bind address should be…
5fe8686 
… set to 127.0.0.1 to kube-scheduler bind address should be set to 127.0.0.1
@karanpopat
Check for PodSecurityPolicy or SecurityContextDeny
5d67ee7
@Priyanka-Chatterjee-2000
add control and queries
956ed5e
@Priyanka-Chatterjee-2000
Merge branch 'add-new-other-checks' of https://github.com/turbot/stea…
0f2e078 
…mpipe-mod-kubernetes-compliance into add-new-other-checks
@Priyanka-Chatterjee-2000
update
fb02303
@khushboo9024
update query
8911b8f
@karanpopat
Fix control descriptions
dcda305
@khushboo9024
update query
67979ba
@khushboo9024
remove comment
1ba093c
@karanpopat karanpopat marked this pull request as draft September 27, 2023 05:51
@karanpopat karanpopat changed the base branch from main to release/v0.14 September 27, 2023 05:52
@Priyanka-Chatterjee-2000 Priyanka-Chatterjee-2000 marked this pull request as ready for review September 28, 2023 10:27
madhushreeray30
madhushreeray30 reviewed Sep 28, 2023
View reviewed changes
Copy link
Contributor

@madhushreeray30 madhushreeray30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Priyanka-Chatterjee-2000 please have a look at the comments, thanks!

all_controls/pod_template.sp Outdated Show resolved Hide resolved
controls/cronjob.sp Outdated Show resolved Hide resolved
controls/cronjob.sp Outdated Show resolved Hide resolved
controls/cronjob.sp Outdated Show resolved Hide resolved
controls/cronjob.sp Outdated Show resolved Hide resolved
query/statefulset.sp Outdated Show resolved Hide resolved
query/statefulset.sp Outdated Show resolved Hide resolved
query/statefulset.sp Outdated Show resolved Hide resolved
query/statefulset.sp Outdated Show resolved Hide resolved
query/statefulset.sp Outdated Show resolved Hide resolved
@Priyanka-Chatterjee-2000 @madhushreeray30
Apply suggestions from code review
966d9b5 
Co-authored-by: Madhushree Ray <madhushree@turbot.com>
madhushreeray30
madhushreeray30 approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@madhushreeray30 madhushreeray30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@misraved misraved merged commit 2ffbfdb into release/v0.14 Sep 29, 2023
@misraved misraved deleted the add-new-other-checks branch September 29, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misraved misraved misraved approved these changes

@madhushreeray30 madhushreeray30 madhushreeray30 approved these changes

@khushboo9024 khushboo9024 Awaiting requested review from khushboo9024

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@karanpopat @misraved @madhushreeray30 @khushboo9024 @Priyanka-Chatterjee-2000 @Subhajit97