Additional Key Columns for aws_accessanalyzer_finding Table

[dbermuehler]

This PR adds the following key columns for the list function of the aws_accessanalyzer_finding table:

• error
• is_public
• resource_owner_account
• resource_type

Integration test logs

Logs

Add passing integration test logs here

Example query results

Results

Add example SQL query results here (please include the input queries as well)

[misraved]

@dbermuehler thank you so much for the PR 👍 !!,

While testing it out, did you see a significant time benefit in adding these columns?

Also, could you please add is_public, resource_owner_account and resource_type to the list of columns as well?

You can use

steampipe-plugin-aws/aws/table_aws_cloudtrail_lookup_event.go

Line 80 in 2c7d699

Transform: transform.FromQual("end_time"),

for additional references.

[misraved]

@dbermuehler we need to handle these errors separately since we are using the ParentHydrate listAccessAnalyzers for this table.

SDK issue reference - turbot/steampipe-plugin-sdk#544

[dbermuehler]

I see! I reverted the changes.

[dbermuehler]

@dbermuehler thank you so much for the PR 👍 !!,

While testing it out, did you see a significant time benefit in adding these columns?

Also, could you please add is_public, resource_owner_account and resource_type to the list of columns as well?

You can use

steampipe-plugin-aws/aws/table_aws_cloudtrail_lookup_event.go

Line 80 in 2c7d699

Transform: transform.FromQual("end_time"),

for additional references.

These key columns exist already as columns for this table.

Regarding speed improvement: I have to admit the increase in speed was quite marginal. For the tests I did it made the queries 1 - 2 seconds faster. This however might be different for bigger data sets then the one I have.