Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default timeout for listing CRDs #235

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

afarid
Copy link
Contributor

@afarid afarid commented Jun 26, 2024

Plugin Version: 0.28.0

Problem

Listing Custom Resource Definitions (CRDs) fails on large clusters.

Investigation

On a large cluster with over 2000 CRDs, we observed that the command .inspect kubernetes did not create tables for custom resource definitions. While all other tables were created successfully, CRD tables were missing.

No errors were found in the logs, so we modified the code to print the error at this location. This revealed that there was a silent timeout during the listing of custom resources, with no error logs or codes returned.

Fix

  1. Remove Custom Timeout: Reverted to using the default timeout same as specified here.
  2. Enhanced Observability: Added error message printing to ensure any issues are logged.

@misraved misraved changed the title Using default timeout for listing CRDs Use default timeout for listing CRDs Jul 5, 2024
@misraved misraved merged commit 6bc8a17 into turbot:main Jul 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants