Blake Sergesketter, Xander Hendry #96
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Styling corrections made to application according to rubocop.
…model tests cover validation, registration tests cover presence of content, and functionality of form, including sad path
…ion. All testing passes. Addition of model and model testing of a user for feature testing of existing users emails.
…ontent on /register page is tested, including sad path
Rubocop setup
User registration page
refactor routes in root welcome page to make all tests passing.
…ting- testing of presence of a link to the home page. All tests passing.
…age it is, a button to discovering movies (no route yet), and a section that lists viewing parties.
User dashboard page
coverage files aren't being ignored by git, even though it's been added to .gitignore
coverage files aren't being ignored
…), update tests as well
…es to movieservice dependent on query
…s and search movies now redirect to the same page
Good work on breaking up the service into some helper methods. Nice use of SRP going on there!
…l of response from movies_controller- show action.
…esting of formatted_runtime. All testing passes.
no coverage in ginthub repo
buh bye!
Movie details
keeping up with main
…sing validation and relationship tests
viewing party db setup
…lude used routes, ensure all tests are passing"
…st creation as well as viewing_party creation
…ete and not passing.
New viewing party mvc
Start of testing a users dahsboard for viewing party. Testing incompl…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't able to get all the way through the project, we got up to creating a new viewing party, but couldn't get our route to create the viewing party and the connecting objects between viewing parties and invited users.