Group autocomplete #624

athoscouto · 2023-09-11T20:45:46Z

Adds autocomplete for group commands.

Adds autocomplete for group names (first argument of most group commands).
Adds autocomplete for group flag in turso db create.
Adds autocomplete for locations on turso group locations add $GROUP ..., only autocompleting missing locations.
Adds autocomplete for locations on turso group locations remove $GROUP ..., only autocompleting existing locations.

gris · 2023-09-11T20:58:39Z

internal/cmd/group.go

+	}
+	for _, group := range groups {
+		if group.Name == name {
+			return group, nil


just a nit: the happy path being nested made this code a bit more difficult to read. but no need to change this at all

athoscouto added 7 commits September 11, 2023 13:12

Add cache functions for groups

5761cfd

Make turso group list populate group cache

1dee54a

Create functions to get groups, group and group names using local cache

b47fb3d

Add group name and remove existing group locations from autocomplete

3812f58

Invalidate groups cache after operations that modify it

37ab1cc

Add autocomplete for the --group flag

2ddd925

Create autocomplete for turso group locations remove cmd

5734566

athoscouto requested a review from gris September 11, 2023 20:45

athoscouto temporarily deployed to internal September 11, 2023 20:45 — with GitHub Actions Inactive

gris approved these changes Sep 11, 2023

View reviewed changes

athoscouto merged commit 9480e3c into main Sep 11, 2023

athoscouto deleted the athos/group-autocomplete branch September 11, 2023 21:31

Provide feedback