Support MSC3395: Synthetic events #157
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turt2live
reviewed
Oct 7, 2022
There was a problem hiding this comment.
This appears to be a reasonable partial implementation for the purposes of spec, though given the minimal review on the MSC side I'm a bit too nervous to include this in the SDK at this time.
For spec purposes, I think that MSC will need a full implementation to demonstrate why the functionality is needed: it doesn't appear as though the usecase is that strong currently.
Will keep this open for another few months to allow the MSC to make some progress, though unfortunately I can't keep this open forever :(
(also apologies for the incredibly late review here...)
|
Per my last comment, I'm nervous about including this with so little review on the MSC - closing until that situation has changed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the spec in matrix-org/matrix-spec-proposals#3395. I've kept the types light (not providing enums for the event types) and expecting bridges to implement the handler logic for those.