Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter for unread emails #5431

Closed
48 of 49 tasks
Tracked by #2347
bedhub opened this issue May 5, 2023 · 5 comments · Fixed by #5518
Closed
48 of 49 tasks
Tracked by #2347

Filter for unread emails #5431

bedhub opened this issue May 5, 2023 · 5 comments · Fixed by #5518
Assignees
Labels
new feature user stories in varying refinement states state:done meets our definition of done state:tested We tested it and are about to release it
Milestone

Comments

@bedhub
Copy link
Contributor

bedhub commented May 5, 2023

As a user i want to have the option to filter my email list so that only the unread or read emails of that list/folder are shown.

AC

  • there is a button inside the mail list toolbar that allows to set a filter on the mail list to only show read email, only show unread emails or to deactivate the filter
  • if you click select all while a filter is active, clicking "select all" will only select mails that match the current filter
  • if more mails are loaded while the filter is active, the filter also applies to the newly loaded mails
  • same with updates coming from outside: if new mail arrives in the list, it's only displayed if it matches current filter
  • filter should be available in the search view  (it should possible to use it in the mobile view)
  • as soon as a set of emails is loaded the filter is applied and the matching results are shown even if there are not enough emails to finish loading.
  • if there are not enough results, loading continues
  • while emails are loading a progress item appears as last list item.
  • there is a cancel button on the progress item in the list to stop the loading.
  • when loading is cancelled the "show more" item appears.

Tasks

  • List refactoring
    • Introduce ListModel
    • Virtual row handling
    • Updates for list items
    • Selection handling
    • Automatic load on scroll
    • Loading indicator & manual load more
    • "load, scroll to and select" based on the url
    • Mobile multiselect
    • Sorting in contact view
    • Swipe items
    • Load all
    • Move shortcut
    • Empty list state
    • Update URL
    • Keep track of selection per folder
    • Focus viewercolumn when we select a mail
    • dragging mails
    • socket for admin client
    • self-healing unread mail counters
    • mutliselect not allowed in some lists
  • Filter
    • Model for the filtered list
    • UI for filtering in the toolbar mail view
    • UI for filtering search view
    • cancelling of loading

Test ntoes

  • Switching between mails
  • Multiselect mails (different methods, including keyboard and checkbox and mobile multiselect)
  • URL is updated correctly
  • Loading the app with mail URL will try to load and display that email
  • Loading more works
  • Cancelling of loading works
  • Network errors are handled correctly
  • Inbox rules are applied
  • Selected folder/mail is remembered when switching between views
  • Filtering mails works
  • Mails don't disappear if they stop matching the filter
  • Loading can be cancelled and resumed
  • Load all still works
  • Load all still works in search
  • Load all works with filters
  • Contact list works
  • Search view works
  • Filters work in search
  • Filters work in mobile mail view
  • Filters work in mobile search view
  • Secure external mails
  • Mailto & MAPI
  • Contact forms
@bedhub bedhub added the new feature user stories in varying refinement states label May 5, 2023
@bedhub bedhub changed the title filter by unread status Filter for unread emails May 5, 2023
@dergigi

This comment was marked as abuse.

@wrdhub wrdhub self-assigned this May 24, 2023
charlag added a commit that referenced this issue Jun 14, 2023
close #5431

Co-authored-by: wrd <wrd@tutao.de>
charlag added a commit that referenced this issue Jun 14, 2023
close #5431

Co-authored-by: wrd <wrd@tutao.de>
charlag added a commit that referenced this issue Jun 14, 2023
close #5431

Co-authored-by: wrd <wrd@tutao.de>
charlag added a commit that referenced this issue Jun 15, 2023
close #5431

Co-authored-by: wrd <wrd@tutao.de>
@charlag charlag added the state:done meets our definition of done label Jun 15, 2023
@charlag charlag added this to the 3.114.2 milestone Jun 15, 2023
charlag added a commit that referenced this issue Jun 15, 2023
Includes rewrite of Mail/Contact/Search views to use ViewModels

close #5431

Co-authored-by: wrd <wrd@tutao.de>
charlag added a commit that referenced this issue Jun 15, 2023
Includes rewrite of Mail/Contact/Search views to use ViewModels

close #5431

Co-authored-by: wrd <wrd@tutao.de>
@vitoreiji vitoreiji self-assigned this Jul 10, 2023
@vitoreiji
Copy link
Contributor

vitoreiji commented Jul 10, 2023

URL is updated correctly

What does "correctly" mean?

@vitoreiji
Copy link
Contributor

Network errors are handled correctly

Again, what does "correctly" mean? Also, which network errors, other than being offline, and how to I trigger them?

@charlag
Copy link
Contributor

charlag commented Jul 10, 2023

URL is updated correctly

What does "correctly" mean?

  • URL is updated every time you switch between folders or mails and only once per switch
  • it remembers the mail per folder
  • it remember the folder that was open before leaving mail view
  • in multiselect the element id part is removed from the URL

@charlag
Copy link
Contributor

charlag commented Jul 10, 2023

Network errors are handled correctly

Again, what does "correctly" mean? Also, which network errors, other than being offline, and how to I trigger them?

You can trigger network errors by breaking the connection, either by actually disconnecting or by using devtools (only works in browser). So yeah it means offline.

It should stop loading and show "load more" button and it should be able to continue when you press on it.

@vitoreiji vitoreiji added the state:tested We tested it and are about to release it label Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature user stories in varying refinement states state:done meets our definition of done state:tested We tested it and are about to release it
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants