Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: The solution was to access the route from the parentTopic and al… #481

Merged
merged 2 commits into from
Sep 11, 2023

Conversation

20041540MichaelKelly
Copy link
Contributor

@20041540MichaelKelly 20041540MichaelKelly commented Sep 10, 2023

…so add in a null safety operator just to ensure against nulls

Please check if the PR fulfills these requirements

  • [ x] The commit message is sensible and easily understood
  • [ x] Tests for the changes have been added (for bug fixes / features where relevant)
  • [x ] Docs have been added / updated (for bug fixes / features where relevant)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

fix: The solution was to access the route from the parentTopic and also add in a null safety operator just to ensure against nulls

What commits does this PR relate to?

  • fix: The solution was to access the route from the parentTopic and also add in a null safety operator just to ensure against nulls (21c8c8a)
  • fix: I added in a ternary conditional to check if type is side and unit to got to lo.parentTopic.route if not go lo.route (a2dd193)

Thank you for your contribution

We hope you stay around and connect with our growing community!

…so add in a null safety operator just to ensure against nulls
@netlify
Copy link

netlify bot commented Sep 10, 2023

Deploy Preview for tutors-dev ready!

Name Link
🔨 Latest commit a2dd193
🔍 Latest deploy log https://app.netlify.com/sites/tutors-dev/deploys/64fdb4a482a4de00085e51f4
😎 Deploy Preview https://deploy-preview-481.tutors.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 52 (🔴 down 5 from production)
Accessibility: 90 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@ghost
Copy link

ghost commented Sep 10, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

…it to got to lo.parentTopic.route if not go lo.route
@edeleastar edeleastar merged commit 8063feb into development Sep 11, 2023
11 checks passed
@github-actions github-actions bot mentioned this pull request Oct 3, 2023
3 tasks
@edeleastar edeleastar deleted the App/Topic-Navigator-Unit-Links-Issue branch November 18, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants