Adding a todo comment, #106

tuzig · May 22, 2024 · 339e1ec · 339e1ec
1 parent 7c6adb6
commit 339e1ec
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/peers/pane.go b/peers/pane.go
@@ -97,7 +97,9 @@ func NewPane(peer *Peer, ws *pty.Winsize, parent int) (*Pane, error) {
 			return nil, fmt.Errorf(
 				"Got a pane request with an illegal parrent pane id: %d", parent)
 		}
-		parent = parentPane.C.Process.Pid
+		//TODO: handle a crash here, when there's a parent pane but no process yet
+		//      https://github.com/tuzig/webexec/issues/106
+		-parent = parentPane.C.Process.Pid
 	}
 	if ws != nil {
 		vt = vt10x.New(vt10x.WithSize(int(ws.Cols), int(ws.Rows)))