Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bower Version Update and Naming Issue #460

Closed
AlJohri opened this issue Nov 1, 2013 · 14 comments
Closed

Bower Version Update and Naming Issue #460

AlJohri opened this issue Nov 1, 2013 · 14 comments
Labels

Comments

@AlJohri
Copy link

AlJohri commented Nov 1, 2013

bower install twitter-bootstrap-sass

currently downloads Bootstrap 2. Is there any chance you can update this to the most recent version of Bootstrap?

Also,

bower install bootstrap-sass

or

bower install sass-bootstrap

currently links to https://github.com/jlong/sass-bootstrap

Any way to fix the naming issue and claim "bootstrap-sass" as is the name of this repository?

@glebm
Copy link
Member

glebm commented Nov 2, 2013

Do we even have a bower version? I don't think so. PR welcome

@ghost
Copy link

ghost commented Nov 2, 2013

@AlJohri : that project is managed by jlong just as it says not by this group of folks

@AlJohri
Copy link
Author

AlJohri commented Nov 21, 2013

@jrobeson, @glebm "twitter-bootstrap-sass" links to THIS repository.

This can be verified here: http://sindresorhus.com/bower-components/#!/search/twitter-bootstrap-sass (takes a second to load) or view the output of bower info below:

➜  ~  bower info twitter-bootstrap-sass
bower twitter-bootstrap-sass#*  cached git://github.com/thomas-mcdonald/bootstrap-sass.git#2.0.3
bower twitter-bootstrap-sass#*  validate 2.0.3 against git://github.com/thomas-mcdonald/bootstrap-sass.git#*

{
  name: 'twitter-bootstrap-sass',
  homepage: 'https://github.com/thomas-mcdonald/bootstrap-sass',
  version: '2.0.3'
}

There must be a valid manifest JSON (bower.json I presume) in the current working directory according to http://bower.io/#registering-packages so I'm confused as to how this currently exists.

All renaming of bower packages is done in this github issue: bower/bower#120

➜  ~  bower search bootstrap | grep jlong
    sass-bootstrap git://github.com/jlong/sass-bootstrap.git
    bootstrap-sass git://github.com/jlong/sass-twitter-bootstrap
➜  ~  bower search bootstrap | grep thomas
    twitter-bootstrap-sass git://github.com/thomas-mcdonald/bootstrap-sass.git

The "bootstrap-sass" package points to a renamed github repo by jlong. I can request to deregister this package and redirect to this version with your permission!

@ghost
Copy link

ghost commented Nov 21, 2013

the opposite naming of bootstrap-sass vs sass-bootstrap is why i thought so.

@glebm
Copy link
Member

glebm commented Nov 21, 2013

Hi @AlJohri! It would be great if you add a valid bower.json file to this repo! bootstrap-sass only works with ruby for now, but that should change soon #473

@jasonschock
Copy link

@AlJohri @glebm Bower is actually looking at this repo's tags to generate the available version numbers. Unfortunately, when the tags changed to add an additional dot-number, i.e. the vN.N.N.N format rather than vN.N.N, it broke the way Bower parses them. So v2.0.3 is the last available version that Bower sees.

The ideal fix would be to simply change the version tags to something semver, which is what Bower prefers. Then you wouldn't even need a manifest file. It would just work.

@glebm
Copy link
Member

glebm commented Dec 4, 2013

Changing the versioning format is not really an option (need both upstream version and ours; rubygems doesn't support + version metadata; there are tens thousands of users with ~> locked dependencies). What's the second best fix?

@jasonschock
Copy link

Good points, and good question. What about a new, additional tag that follows semver, but is intended only for Bower consumption? E.g. something like v3.0.2-bower. Perhaps v3.0.2-bower.1, v3.0.2-bower.2 to capture that last .N somehow. (The importance [and formatting] of that is debatable, IMO.)

It's also worth noting that a user can just force-install a specific tag/SHA like so:

bower install '<git-url>#<git-tag-or-sha>'

(This solved the issue for me.)

I think it's a question for @glebm, et. all, how important Bower support is vs. the extra effort it will take to implement an additional tagging scheme and/or create & maintain a package file.

@glebm
Copy link
Member

glebm commented Dec 5, 2013

@jasonschock Bower support is important, we can mention bower install '<git-url>#<git-tag-or-sha>' in the readme and set the version in bower.json. This package is going to move to twbs/boostrap-sass (ed tom) soon, that's when we can change the bower registry.

@glebm
Copy link
Member

glebm commented Dec 11, 2013

This issue depends on #481

@glebm
Copy link
Member

glebm commented Dec 20, 2013

@jasonschock @AlJohri @jrobeson Could you guys look at #488 and comment if it's OK

@glebm
Copy link
Member

glebm commented Jan 7, 2014

It appears there is no solution to compatible version numbers short of fixing SemVer itself. I found the relevant SemVer issue and outlined the problem there: semver/semver#168

@thomas-mcdonald
Copy link
Member

I don't really know if it's 'fixing' semver, given we're not following it. I think @mdo wants us to move to being pegged to upstream's releases, which is fine, we could retain the .z for Rubygems though?

@glebm
Copy link
Member

glebm commented Jan 30, 2014

We have switched to v3.1.0 scheme for all non-rubygems versions as of now!

@glebm glebm closed this as completed Jan 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants