Pure Sass support #473
Pure Sass support #473
Conversation
|
Added $bootstrap-sass-asset-helper, to allow using outside ruby. |
|
+1, let's get this in |
|
❤️ ❤️ ❤️ Turned out to be quite the elegant solution. |
| @@ -117,6 +123,10 @@ def convert_to_scss(file) | |||
| file | |||
| end | |||
|
|
|||
| def replace_asset_url(rule, type) | |||
| replace_all rule, /url\((.*?)\)/, "url(if($bootstrap-sass-asset-helper, twbs-#{type}-path(\\1), \\1))" | |||
There was a problem hiding this comment.
Sorry to kick an old PR, but this if syntax is invalid Sass and blows up node-sass/libsass compilation
There was a problem hiding this comment.
Awesome that you tried this on node-sass! How does it fail exactly? Would you add a test for compiling with it?
The syntax is valid and is specified here: http://sass-lang.com/documentation/Sass/Script/Functions.html#if-instance_method
It also appears to be supported by libsass: https://github.com/hcatlin/libsass/blob/master/functions.cpp#L959-L961
There was a problem hiding this comment.
Thanks, I didn't realize there was an IIF like function in Sass. The actual error is bootstrap/mixins:336: error: non-terminal statement or declaration must end with ';'
There was a problem hiding this comment.
It does look like the if instance is available in libsass https://github.com/hcatlin/libsass/blob/master/functions.cpp#L959
@thomas-mcdonald What do you think?
This uses custom functions, which is flexible but not ideal for people trying to use this not in the ruby world.
Also exposes
$bootstrap-sass-asset-helper(default: true), to allow using outside ruby.