Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider renaming .form-control-label #18573

Closed
cvrebert opened this issue Dec 14, 2015 · 3 comments
Closed

Consider renaming .form-control-label #18573

cvrebert opened this issue Dec 14, 2015 · 3 comments
Labels
css v4
Milestone
v4.0.0-alpha.3

Comments

@cvrebert
Copy link
Collaborator

FWICT, it's currently only meant for grid-based forms (see #17498, #18571), but the class's name doesn't communicate this at all.
Perhaps add something like grid or col to the name? e.g. .col-form-label
@cvrebert
Copy link
Collaborator Author

cvrebert commented Feb 9, 2016

CC: @mdo for feedback

@mdo mdo mentioned this issue Feb 9, 2016
Merged
5 tasks
@mdo mdo added this to the v4.0.0-alpha.3 milestone Apr 9, 2016
mdo added a commit that referenced this issue Apr 9, 2016
@mdo
Fixes #18573: Change name of .form-control-label to .col-form-label (…
0a4d315 
…and .form-control-legend to .col-form-legend) to reiterate use for only grid layouts
@mdo
Copy link
Member

mdo commented Apr 9, 2016

Fixed in 0a4d315 with #19141.

@mdo mdo closed this as completed Apr 9, 2016
@mdo mdo mentioned this issue May 11, 2016
Closed
@Herst Herst mentioned this issue Sep 4, 2017
Closed
@Herst
Copy link
Contributor

Herst commented Sep 4, 2017

There are still some remains of .form-control-label and the migration docs still mention it as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
css v4
Projects
None yet
Milestone
v4.0.0-alpha.3
Development

No branches or pull requests
3 participants
@mdo @cvrebert @Herst