Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues for .fixed-top/.fixed-bottom navbars (Bootstrap v4.0.0-beta) #24260

Closed
vadikom opened this issue Oct 5, 2017 · 7 comments
Closed

Issues for .fixed-top/.fixed-bottom navbars (Bootstrap v4.0.0-beta) #24260

vadikom opened this issue Oct 5, 2017 · 7 comments

Comments

@vadikom
Copy link

vadikom commented Oct 5, 2017

Hey guys, here's a short list of issues I stumbled upon in Bootstrap v4.0.0-beta (while working on the Bootstrap 4 addon for SmartMenus jQuery):

  1. For .fixed-top/.fixed-bottom navbars .navbar-collapse doesn't have something like overflow-y: auto; max-height: 360px; (as in BS3) so the content cannot be scrolled and might be cut if too tall.
  2. For .fixed-bottom navbars dropdowns are not properly positioned above the navbar.
  3. For .fixed-bottom navbars .dropdown-toggle carets do not point up.

All these are demonstrated and can be tested here:

https://codepen.io/vadikom/pen/EwoKyz

@Johann-S
Copy link
Member

Johann-S commented Oct 5, 2017

For your two last points :
if you want dropdowns positionned above the navbar use .dropup

Side note: in beta 1 we have issue with dropup in navbar but it's already fixed in our current code and will be available in our next release

btw nice plugin 😉

@vadikom
Copy link
Author

vadikom commented Oct 5, 2017

Ah, I missed .dropup, thanks!

BTW, sorry for a dumb question I guess - in which branch is your most current dropdown code? Thanks!

@Johann-S
Copy link
Member

Johann-S commented Oct 5, 2017

use our v4-dev branch 👍

@mdo
Copy link
Member

mdo commented Oct 18, 2017

Oh man we could totally use viewport units for the fixed navbar now. v3 didn't allow for it given browser support, but we can definitely do it now. http://caniuse.com/#feat=viewport-units

@XhmikosR
Copy link
Member

@Johann-S @mdo: that is why the bottom navbar example doesn't look good in small res? I haven't had the time to dig into this, just noticed it.

screen shot 2017-10-20 at 02 00 32-fullpage

@mukhammad-akilov
Copy link

mukhammad-akilov commented Oct 23, 2017

Don't you forget about max-height: % and overflow-y: scroll for .navbar-collapse if navbar is fixed?

@mdo
Copy link
Member

mdo commented Nov 15, 2017

Punting second part of this to #24796.

@mdo mdo closed this as completed Nov 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants