text-hide() warning message

[arechsteiner]

When building the new 4.1 scss source code, I get the following warning message:

alex@ubuntuVM:~/code/bootstrap-41/scss$ scss bootstrap.scss  bootstrap.css
WARNING: The `text-hide()` mixin has been deprecated as of v4.1.0. It will be removed entirely in v5.
         on line 10 of mixins/_text-hide.scss, in `text-hide'
         from line 57 of utilities/_text.scss
         from line 14 of _utilities.scss
         from line 41 of bootstrap.scss

It seems text-hide() ist still used in https://github.com/twbs/bootstrap/blob/v4.1.0/scss/utilities/_text.scss#L57

[XhmikosR]

Yes, but it's deprecated; that is the whole point of the warning message. :)

/CC @mdo

[arechsteiner]

I feel like the vanilla Bootstrap source code shouldn't spawn warning messages about itself.

I have some projects where I build custom versions of Bootstrap and they all spawn warnings now even though I'm not using text-hide() and am perfectly innocent. 😇

[XhmikosR]

Yeah unfortunately that is correct. I'm not sure if it's technically possible to achieve what we want without removing the actual mixin call and atill show the warning. If your anyone else finds a way, let us know.

…

On Tue, Apr 10, 2018, 12:07 Alexander Rechsteiner ***@***.***> wrote: I feel like the vanilla Bootstrap source code shouldn't spawn warning messages about itself. I have some projects where I build custom versions of Bootstrap and they all spawn warnings now even though I'm not using text-hide() and am perfectly innocent. 😇 — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#26237 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAVVteowijpDpdmjYZBtUk4l6ENuCEqGks5tnHZUgaJpZM4TNy1i> .

[arechsteiner]

One solution I can think of:

Mixin:

@mixin text-hide($ignoreWarning: false) {
  ...
  @if ($ignoreWarning == false) {
    @warn "The `text-hide()` mixin has been deprecated as of v4.1.0. It will be removed entirely in v5.";
  }
}

Usage in _text.scss

.text-hide {
  @include text-hide(true);
}

This will spawn a warning for normal use of text-hide() but gives the option to suppress the warning.

[XhmikosR]

Hmm, nice approach. Can you make a PR and CC me?

…

On Tue, Apr 10, 2018, 12:37 Alexander Rechsteiner ***@***.***> wrote: One solution I can think of: Mixin: @mixin text-hide($ignoreWarning: false) { ... @if ($ignoreWarning == false) { @warn "The `text-hide()` mixin has been deprecated as of v4.1.0. It will be removed entirely in v5."; } } Usage in _text.scss .text-hide { @include text-hide(true); } This will spawn a warning for normal use of text-hide() but gives the option to suppress the warning. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#26237 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAVVtWXTWvOgQo69udJRkjJ20YQG1qA5ks5tnH1tgaJpZM4TNy1i> .

[arechsteiner]

Will do, give me half an hour.

[arechsteiner]

Done here: #26242

[TheSharpieOne]

Usually when there is a deprecation warning about something going to be remove, the package itself doesn't use that thing. Typically I see the package migrating to the new preferred usage, and others can use that commit as an example way to migrate any of their own usage.
It seems like bootstrap is planning on removing something and are not quite sure what to do when it gets removed. Leaving others to determine that for themselves and also warning them that bootstrap will break itself in the next version unless bootstrap takes additional action (which they obviously will and really doesn't make any sense to tell the user).

[Merovex]

I just commented out the warning...since I don't use the feature. ;)