Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal, navbar fixed-top, margin-right 16px and overflow scrollbar. #26489

Closed
ghost opened this issue May 11, 2018 · 4 comments
Closed

Modal, navbar fixed-top, margin-right 16px and overflow scrollbar. #26489

ghost opened this issue May 11, 2018 · 4 comments

Comments

@ghost
Copy link

ghost commented May 11, 2018

Bootstrap v4.1.1.

When I use header navbar fixed-top and I open a modal and it adds margin-right: 16px to the body element the navbar fixed-top doesn't move to the left like all the page.

If I use sticky-top (at least in Chrome) it works.

Is it really useful to add that margin-right: 16px ?

Can we agree on leave there the scrollbar? Why we need to hide it?

Also in some retina display I can really see some pixel movement when I open modal, as if we were to use 17px.

@Johann-S
Copy link
Member

seems related to: #25745

@zalog am I right ?

@zalog
Copy link
Contributor

zalog commented May 11, 2018

Yep, it is.

@Johann-S
Copy link
Member

Closed because it's related to @zalog, I hope you'll have time to update your unit test 😉

@zalog
Copy link
Contributor

zalog commented May 11, 2018

Yeah, we must do that :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants