fix(js): removes .modal .navbar-toggler margin

[zalog]

The problem is that .navbar-toggler flips left when we open a bs modal dialog (gif or pen below).

I don't think we need to adjust .navbar-toggler in this case.
We'll always have a parent that manage to adjust the missing scroll width:

• in case of a .fixed-* we have padding-right on that
• in case of a no fixed navbar, we have padding-right on body

Here you have a pen and a demo:

What do you think?

[ysds]

@zalog Thanks! (x-ref: #25417)

[Johann-S]

Please fix unit tests and it would be rad 👍

[zalog]

Yep, done. We're on green now.

[Johann-S]

Deleted our unit test, isn't a good solution, unless this case is already covered by a present unit test

[zalog]

I deleted the tests about $('<div class="navbar-toggler"></div>') because we don't need to test for margin-right. Now, after the first commit from this pr, we are not handling .navbar-toggler from js anymore.

Hmm... or is something that I'm missing? Sorry

[Johann-S]

But you made some changes, so we should test that

[twbs-closer]

Hey there!

We're automatically closing this issue since the original poster (or another commenter) hasn't yet responded to the question or request made to them 14 days ago. We therefore assume that the user has lost interest or resolved the problem on their own. Closed issues that remain inactive for a long period may get automatically locked.

Don't worry though; if this is in error, let us know with a comment and we'll be happy to reopen the issue.

Thanks!

(Please note that this is an automated comment.)