Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update image previews on the Bootstrap examples page #30286

Closed
MartijnCuppens opened this issue Feb 25, 2020 · 4 comments
Closed

Update image previews on the Bootstrap examples page #30286

MartijnCuppens opened this issue Feb 25, 2020 · 4 comments

Comments

@MartijnCuppens
Copy link
Member

MartijnCuppens commented Feb 25, 2020

Although they are a visual enhancement, they are quite hard to maintain. The colors have changed in v5 and probably the grid gutters and carousel navigation will follow.

I would prefer to ditch them unless we can easily automate the image generation process.

https://twbs-bootstrap.netlify.com/docs/5.0/examples/#content

EDIT (XhmikosR): Also, we should resize them to the dimensions we need them to be.

@mdo
Copy link
Member

mdo commented Feb 25, 2020

I'm still happy to maintain this page and keep the screenshots. I think they're super useful. Not going to do it until clearer milestones for v5 though, so I could probably squeeze it in for the first alpha.

@XhmikosR
Copy link
Member

I agree they are helpful, and updating them once a year or so it's not a big deal. Automating this seems a bit too much at this point, but Hugo could do it for us if we wanted in the future (assuming we still have only the 2x images committed and we generate the 1x ones).

@MartijnCuppens MartijnCuppens changed the title Remove image previews from Bootstrap examples page Update image previews on the Bootstrap examples page Feb 26, 2020
@MartijnCuppens
Copy link
Member Author

Ok, I've changed the title and added this to the latest v5 board, just so we don't forget to do this before v5 launches.

@mdo
Copy link
Member

mdo commented Mar 23, 2021

This was done in #33214.

@mdo mdo closed this as completed Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants