Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update examples #33214

Merged
merged 9 commits into from
Mar 22, 2021
Merged

Update examples #33214

merged 9 commits into from
Mar 22, 2021

Conversation

mdo
Copy link
Member

@mdo mdo commented Feb 26, 2021

  • Create new jumbotron example (fixes Jumbotron example missing in v5 #32161)
  • Refresh styles of several examples
    • Pricing
    • Starter template (cross link to npm and parcel)
    • Checkout
  • Add some new component series snippet example
    • Heroes
    • Headers
    • Features
    • Sidebars
  • Add sidebar to Examples page with list of them
  • Take new screenshots
  • Improve image compression
  • Decide what to do with the unsplash images? Shouldn't we serve them?
  • Test zip-examples script and output

Preview: https://deploy-preview-33214--twbs-bootstrap.netlify.app/docs/5.0/examples/

@mdo mdo marked this pull request as ready for review March 15, 2021 04:05
@mdo mdo requested review from a team as code owners March 15, 2021 04:05
@mdo mdo force-pushed the examples branch 2 times, most recently from 63df438 to 3bf5ee0 Compare March 15, 2021 06:51
@XhmikosR XhmikosR force-pushed the examples branch 2 times, most recently from 76e1ff0 to 0e164a8 Compare March 15, 2021 14:24
@mdo mdo force-pushed the examples branch 2 times, most recently from dda613c to 9736d40 Compare March 17, 2021 05:22
@mdo
Copy link
Member Author

mdo commented Mar 17, 2021

@XhmikosR This should be good based on the todo list at the top. I may have force pushed over a commit of yours, sorry!

@XhmikosR
Copy link
Member

I'll review later today :)

I'm having second thoughts about the new example images being in content, but maybe it's simpler that way. It's just that I find it easier to look for assets only in one place. I'll see if it complicates things, and if it does I'll leave it as is.

@mdo
Copy link
Member Author

mdo commented Mar 17, 2021

I'm having second thoughts about the new example images being in content, but maybe it's simpler that way. It's just that I find it easier to look for assets only in one place. I'll see if it complicates things, and if it does I'll leave it as is.

Yeah, I was wondering about that. My thinking is that it'd be helpful to have everything self contained for each example where appropriate. These are, when built and zipped up, meant to be self contained demos so I care less how we get there and just that it's easy for folks to get and use :).

@mdo mdo merged commit a3ad732 into main Mar 22, 2021
@mdo mdo deleted the examples branch March 22, 2021 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jumbotron example missing in v5
2 participants