Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jumbotron example missing in v5 #32161

Closed
9mido opened this issue Nov 16, 2020 · 6 comments · Fixed by #33214
Closed

Jumbotron example missing in v5 #32161

9mido opened this issue Nov 16, 2020 · 6 comments · Fixed by #33214

Comments

@9mido
Copy link

9mido commented Nov 16, 2020

https://v5.getbootstrap.com/docs/5.0/examples/

https://getbootstrap.com/docs/4.0/examples/jumbotron/

The jumbotron example from v4 is missing in the v5 examples. Can the bootstrap team please create a replacement example on the v5 example webpage for users who wish to upgrade from the v4 jumbotron example to a compatible v5 example?

@9mido 9mido added the feature label Nov 16, 2020
@josephcrowell
Copy link

There is no Jumbotron in v5 but the functionality can be recreated easily enough per: https://stackoverflow.com/questions/63141494/how-to-create-jumbotron-in-bootstrap-5

I believe this is also documented somewhere in the migration docs but can't find where at the moment.

@9mido
Copy link
Author

9mido commented Nov 16, 2020

Thanks for that stackoverflow link. But are the answers in that link bootstrap team recommendations and best practices?

Well, if it is not in the docs it should be added, and perhaps more easily found if you cannot find it.

@XhmikosR
Copy link
Member

@XhmikosR
Copy link
Member

Or do you mean, you want a clear example how to do this in v5 with the utility examples in our docs?

@mdo: perhaps we should expand the migration notes or something?

@XhmikosR XhmikosR reopened this Nov 16, 2020
@9mido
Copy link
Author

9mido commented Nov 16, 2020

@XhmikosR

Yes I saw that link you provided already.

Yes a clear example and expanding the migration notes would be nice.

It is sort of like a missing piece where a full example was shown in v4 but nothing except one sentence was shown in v5 it will leave people confused how to upgrade their v4 jumbotrons to v5 without showing a full example. Plus, not all websites would prefer to use the 'product' example and would rather have the look and feel of the old jumbotron v4 example in v5.

@mdo
Copy link
Member

mdo commented Jan 14, 2021

https://codepen.io/emdeoh/pen/ZEpmOPE

There’s a quick pass at doing something in a Codepen with nothing but utilities. Bringing back an example would be helpful I think.

@mdo mdo mentioned this issue Feb 26, 2021
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants