-
-
Notifications
You must be signed in to change notification settings - Fork 78.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link old Bootstrap docs to latest release #31980
Comments
You can also take a dynamic approach:
The fetch documentation database for each version can even be just plain Search engines will see the common links as there's no version number in the URL anymore, which is great for both the people who want the latest version and those who still using the older versions. The dropdown version value can be passed using a |
as documentation is static, maybe store a file with versions value in json format, and load that file in Javascript
|
A dynamic way would be to find if Github provide an API, which allow us to fetch our tags and use our tags to select a version (+ a bit of JavaScript) |
What about only linking to latest (for each major) only, using a simple redirection? We may use This would help with maintenance a lot since we'd only have links to majors—and replacing those dropdowns everywhere would be done once (and updated for each major, which isn't that frequent). |
That doable for sure, and easy to maintain. We'd still need to change the old live docs to read A more flexible approach would be to have a placeholder HTML, then use JS to fetch our docs and create the toggler client-side. That would probably have a speed penalty, though. Plus if we host the version file on GitHub, their API limits might apply. |
My ticket #36189 was closed as a duplicate of this one, but I had actually read this ticket before filing mine :-P I feel like I suggested things that were quite different from what has been discussed here thus far. Hope you will take that into consideration and read my ticket if/when you do any work towards this. Thank you! Of course if you want I'll gladly repeat the highlights from it here. EDIT: That said, I must say I do commend you a lot for keeping a much cleaner issue tracker than most other projects this size. That's not a small feat at all. |
Part of this has been addressed in #35736 with the versions dropdown in the navbar now pointing to previous versions of the current page. Still TBD on how much we update in the live docs for our older versions. |
I'm just going to mention my idea from issue #36189 again, because I don't think @mdo understood what I meant. One of the easiest way to solve this and make pull requests like #37002 and this ticket unnecessary is to add another URL alias to the site; for example Then every old doc version dropdown or header or whatever can just be updated to add a link to Does that make sense? Again, @mdo closed my ticket #36189 (where I tried to explain this idea, but I am probably bad at explaining) as a duplicate of this ticket. But it isn't a duplicate. My idea for fixing this hassle is completely different. |
this would make sense to me. @mdo et al, have a think (unless there was another good reason not to do it) |
FYI if it can help, we began to work on "latest" URLs in Boosted: Orange-OpenSource/Orange-Boosted-Bootstrap#1088 (with the system of aliases) in order to have things like: |
Not that I have much weight on the topic, as I dont do any work on the library or anything... But a significantly easier method to maintain is to use a component based framework. That's not to say that there wouldn't be a lot of work to be done. But honestly, probably not an absolute monolith amount once you get passed the repetitive layout items. My focus is Vue so obviously I'm going to lean from there... but a full fledged Vue SPA could make this a lot simpler as everything would under a global layout, one place, one code to maintain when theres a change. However, Vue could also be used as an single injectable, where the dropdown js is written in one place, then mounted into the page. So, could be an alternative for single replacements. Just saying, an all around Vue app, Nuxt app, or React app would make a lot of this all easier 🤔 Just saying, it would take some work, but would make maintenance exponentially easier. I made a PR that updated the dropdowns in v5, however, I could technically extend the update for v4 and v3. It's really a simple search and replace job that vscode can easily do. |
FYI we just merged Orange-OpenSource/Orange-Boosted-Bootstrap#1088 into Boosted which is available in Boosted v5.2.1. As an example now:
More details can be found in the PR. |
I suppose we can have the same results without adding new aliases #36805 |
This likely is going to be a pain in the ass, but I wanted to capture some thoughts regardless of where we land on it. My hope is that we can put some time into our old v4.x docs and update them with new outdated release banners and links to the latest versions of each page in our versions pickers. I'd like help brainstorming our approach to this, because right now all I can think of is manually doing it one by one.
Two things are on my mind for it.
Updated new release banner
First is updating the release banner, and adding it to all previous v4.x releases.
Right now there's a thin banner on the 4.0, 4.1, and 4.2 docs. We don't have them on 4.3 or 4.4, and soon 4.5 (after we ship our next v4.6.0 release). At a minimum, we need to:
And for the stretch goal, we take it 1-2 steps further:
https://getbootstrap.com
on every banner)Updated versions dropdown
Beyond the new version banners, I'd like us to do something more with our versions dropdowns in the navbar. Each version of our docs (4.0–4.5) is different, which leads to unfortunate experiences of viewing outdated docs and not being able to easily jump to the latest version of the page.
Question is, do we include every version like so?
Or, do we do the version you're reading, the latest v4.x, and the latest v5.x like so?
And, lastly, for all v4 and v5 versions dropdowns, do we include links to v3 and v2? Thinking we can drop those with these changes, and keep the
All versions
link.v3?
Beyond v4's docs, I'm wondering if we need to update v3.4's docs to modify the new release banner and versions dropdown. Thinking we modify the text in the banner to mention v4 and v5. With the dropdown, I'm thinking we remove the v4 alpha 6 release finally, update
Latest (4.x)
toBootstrap v4.x
, and addBootstrap v5.x
. Both the v4 and v5 could point to their latest releases instead of all the releases.Screenshots of dropdowns
Just for quick comparison...
What do you think @twbs/team?
The text was updated successfully, but these errors were encountered: