-
-
Notifications
You must be signed in to change notification settings - Fork 78.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update new docs version picker to work on home and examples pages #36245
Conversation
For more context on why we would keep this version picker, see #31980. We've had a handful of issues and more requests to better support jumping between versions of specific pages. Across major versions, we need better linking and some updates for the previous major versions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm closing #36221 based on the content of this PR that fixes the blocking issues. As said in the description what remains is figuring out what to do about two situations.
Let's keep in mind that it would be safer in the future to wait for the beginning of a major version to change the sitemap of the documentation (e.g. moving or renaming some sections). Otherwise, between minor versions, if the sitemap of the documentation changes too much, it will result in a lot of 404s.
Don't know if it would be feasible but while I was testing this PR, one possible evolution would be to keep the anchor links as well:
- http://localhost:9001/docs/5.1/components/dropdowns/#dropup would redirect to https://getbootstrap.com/docs/5.0/components/dropdowns/#dropup
- http://localhost:9001/docs/5.1/components/dropdowns/#dropup-centered would redirect to https://getbootstrap.com/docs/5.0/components/dropdowns/#dropup-centered and since it doesn't exist, it will still display the top of the page.
074ae04
to
41a9f24
Compare
Definitely. No major restructuring of pages here. Only thing we should have to worry about is new pages, which we've accounted for with the
I'm going to skip that for now, definitely a nice to have. Also a little tougher since the headings can change between versions (e.g., |
41a9f24
to
8a1cf74
Compare
Alternate fix to #36221.
This doesn't address every issue, but it fixes the broken links for Home and Examples. This also fixes the 404 for the
utilities/opacity/
page. What remains is figuring out what to do about two situations:TBD on both those.
/cc @julien-deramond