Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal Backdrop Z-Index should be higher than Offcanvas Z-index. #34164

Closed
jeddtobee023 opened this issue Jun 2, 2021 · 3 comments
Closed

Modal Backdrop Z-Index should be higher than Offcanvas Z-index. #34164

jeddtobee023 opened this issue Jun 2, 2021 · 3 comments
Labels

Comments

@jeddtobee023
Copy link

By default,
$zindex-modal-backdrop: 1040;
$zindex-offcanvas: 1050;
$zindex-modal: 1060;

I think it should be like this:
$zindex-offcanvas: 1040;
$zindex-modal-backdrop: 1050;
$zindex-modal: 1060;

So that when a button in offcanvas supposed to open a modal, the offcanvas would not overlap to the modal backdrop.

@ffoodd
Copy link
Member

ffoodd commented Jun 3, 2021

I guess we need a separate variable for offcanvas' backdrop then, since offcanvas uses a backdrop too. @GeoSot am I right?

@GeoSot
Copy link
Member

GeoSot commented Jun 3, 2021

On a first thought, seems valid, as modal backdrop z-index is less that offcanvas
And if we go with this, we have to take a look on #34149

@mdo
Copy link
Member

mdo commented Feb 17, 2022

This was done awhile back.

bootstrap/scss/_variables.scss

Lines 1031 to 1039 in 63f75bc

$zindex-dropdown: 1000 !default;
$zindex-sticky: 1020 !default;
$zindex-fixed: 1030 !default;
$zindex-offcanvas-backdrop: 1040 !default;
$zindex-offcanvas: 1045 !default;
$zindex-modal-backdrop: 1050 !default;
$zindex-modal: 1055 !default;
$zindex-popover: 1070 !default;
$zindex-tooltip: 1080 !default;

@mdo mdo closed this as completed Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants