-
-
Notifications
You must be signed in to change notification settings - Fork 79k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Variabilize backdrop class name (#34094) #34149
Conversation
@romdum I did some cleanup in order to help this on track. I hope you don't mind @twbs/css-review any help on the sccs? The main cause for now is just to extend the In order to avoid duplication, one Idea is to use a new file |
- Update modal and offcanvas backdrops to use the mixin (placeholder wouldn't work with params I believe) - Plus, modals and offcanvases should be able to be used together, so separate values for z-index (already implemented) are reflected properly here. - Offcanvas still extends modals variables by default, save for z-index
Js scoped, seems ok |
Thanks for the fix lol, I must have been braindead earlier. I pushed another change to fix our z-indexes. I'll make sure to cover this in our highlights for the blog post btw. New z-indexes make more sense now IMO. |
I'm on airplane wifi and I screwed up the push, so this was merged to |
1 similar comment
I'm on airplane wifi and I screwed up the push, so this was merged to |
To resolve #34094, create a new class
offcanvas-backdrop
which extendsmodal-backdrop
. It helps avoid confusion if an offcanvas and a modal is open and two backdrop are shown.