Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Active Nav Tabs are not displayed correctly in the current main branch #35986

Closed
3 tasks done
jonnysp opened this issue Mar 10, 2022 · 2 comments · Fixed by #35996
Closed
3 tasks done

Active Nav Tabs are not displayed correctly in the current main branch #35986

jonnysp opened this issue Mar 10, 2022 · 2 comments · Fixed by #35996

Comments

@jonnysp
Copy link
Contributor

jonnysp commented Mar 10, 2022

Prerequisites

Describe the issue

current release looks good https://getbootstrap.com/docs/5.1/components/navs-tabs/#javascript-behavior
grafik

current brunch looks bad https://twbs-bootstrap.netlify.app/docs/5.1/components/navs-tabs/#javascript-behavior
grafik

Reduced test cases

https://getbootstrap.com/docs/5.1/components/navs-tabs/#javascript-behavior
https://twbs-bootstrap.netlify.app/docs/5.1/components/navs-tabs/#javascript-behavior

What operating system(s) are you seeing the problem on?

Windows

What browser(s) are you seeing the problem on?

Chrome, Firefox, Microsoft Edge

What version of Bootstrap are you using?

v5.1.3 and Current main Brunch

@XhmikosR XhmikosR changed the title Active Nav Tabs are not displayed correctly in the current main brunch Active Nav Tabs are not displayed correctly in the current main branch Mar 10, 2022
@mdo
Copy link
Member

mdo commented Mar 10, 2022

Same applies to our list groups and pagination. This is because we were doing some lazy Sass math like -$list-group-border-width, which with the CSS vars change for border-width, was generating -var(--bs-border-width) in our compiled CSS.

This does make me think we could either fix the problem with calc(), or we could call this a breaking change and drop it until a v6 when we can clean up all these things. I'm 50/50 and could go either way.

Thoughts?

@jonnysp
Copy link
Contributor Author

jonnysp commented Mar 11, 2022

works for me, can be applied

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants