Add some calc() for manipulating new CSS variable version of border-width
#35996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffoodd
approved these changes
Mar 11, 2022
mdo
force-pushed
the
css-var-border-width-fixes
branch
from
491dd7d
to
7dcd556
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We rely on some lazy Sass math like
-$border-width, so in these early steps of migrating to CSS variables, we're bound to find some issues. In this case, we're generating bad CSS because of that lazy math (-var(--bs-border-width)). The fix is usingcalc()to multiply by-1. I thought about reverting the change for these instances, but it'd just be ducking the inevitable, so decided to push it here for now.Fixes #35986.