Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No visual differentiation between active and disabled links in dark mode dropdown menus #37974

Closed
3 tasks done
Sanx78 opened this issue Jan 30, 2023 · 5 comments · Fixed by #37998
Closed
3 tasks done

Comments

@Sanx78
Copy link

Sanx78 commented Jan 30, 2023

Prerequisites

Describe the issue

In 5.3 Alpha 1, there is no visual differentiation between active and disabled links in dark mode dropdown menus. This has been tested in Safari on iOS and in Chrome/Edge on Windows.

Active links are set to --bs-dropdown-link-color, which itself inherits --bs-body-color. Disabled links are set to --bs-dropdown-link-disabled-color which is set to #adb5bd. In dark mode, --bs-body-color is also set to #adb5bd.

This can be seen on the Bootstrap 5.3 doco page for dropdowns: https://getbootstrap.com/docs/5.3/components/dropdowns/#disabled

Reduced test cases

Issue demo here:
https://codepen.io/Sanx78/pen/YzjjLEy

My personal fix (likely to be hated as it is a large sledgehammer for a very small nut) is here:
https://codepen.io/Sanx78/pen/GRBBdOj

However, what I imagine will be the "correct" way of fixing it is to make --bs-dropdown-link-disabled-color theme aware.

What operating system(s) are you seeing the problem on?

Windows

What browser(s) are you seeing the problem on?

Microsoft Edge

What version of Bootstrap are you using?

5.3.0 Alpha 1

@MaruthiKo
Copy link

MaruthiKo commented Jan 30, 2023

I would love to work on this issue
Would need a little guidance on how to solve this issue

@Sanx78
Copy link
Author

Sanx78 commented Jan 31, 2023

Sorry, https://codepen.io/Sanx78/pen/GRBBdOj updated to actually contain the proposed fix.

@MaruthiKo
Copy link

Oh okay cool
I will work on this now

@MaruthiKo
Copy link

MaruthiKo commented Jan 31, 2023

I'm planning on adding the changes to bootstrap/scss/_variables.scss would that be fine to fix this issue
There is a variable that defines the color of the disabled dark dropdown

@MaruthiKo MaruthiKo mentioned this issue Jan 31, 2023
10 tasks
@MaruthiKo
Copy link

@Sanx78 Please have a look at my pull request and let me know if it solves your issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants