Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt Fix #37974 #37981

Closed
wants to merge 1 commit into from
Closed

Attempt Fix #37974 #37981

wants to merge 1 commit into from

Conversation

MaruthiKo
Copy link

Description

Attempt to fix issue #37974: No visual differentiation between active and disabled links in dark mode dropdown menus

I have changed the variable dropdown-dark-link-disabled-color to #dedad6

Motivation & Context

There is no difference between dropdown disabled links in dark mode. By changing the color of dropdown disabled links users can differentiate them and it helps in making the UX better

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Attempt to fix issue #37974: No visual differentiation between active and disabled links in dark mode dropdown menus
I have changed the variable dropdown-dark-link-disabled-color to #dedad6
@MaruthiKo MaruthiKo requested a review from a team as a code owner January 31, 2023 05:21
@mdo
Copy link
Member

mdo commented Feb 4, 2023

Thanks, but #37998 is a more appropriate fix.

@mdo mdo closed this Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants