Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: add/unify advice on contextual colors and accessibility #19255

Merged
merged 1 commit into from
Feb 17, 2016
Merged

Docs: add/unify advice on contextual colors and accessibility #19255

merged 1 commit into from
Feb 17, 2016

Conversation

patrickhlauke
Copy link
Member

  • generalises the callout warning about conveying meaning to assistive technologies when using color modifiers
  • to avoid repetition, externalises the callout as a markdown include
  • adds (admittedly wordy) code to include (and parse) the markdown include in appropriate places throughout the documentation, whenever color modifiers are used

Successor to / closes #18676

@patrickhlauke patrickhlauke added this to the v4.0.0-alpha.3 milestone Feb 17, 2016
@patrickhlauke
- Conveying color meaning to AT as markdown include
40aee93 
- Add/replace callout for color and AT with include
@patrickhlauke patrickhlauke mentioned this pull request Feb 17, 2016
Closed
@patrickhlauke
Copy link
Member Author

/cc @cvrebert for thoughts on the approach...

@patrickhlauke
Copy link
Member Author

also /cc @mdo to check if he's happy with this approach of markdown includes going forward?

@mdo
Copy link
Member

mdo commented Feb 17, 2016

:shipit:

patrickhlauke added a commit that referenced this pull request Feb 17, 2016
@patrickhlauke
Merge pull request #19255 from patrickhlauke/color-accessibility-call…
fb1d511 
…out-include

Docs: add/unify advice on contextual colors and accessibility
@patrickhlauke patrickhlauke merged commit fb1d511 into twbs:v4-dev Feb 17, 2016
@mdo mdo mentioned this pull request Feb 17, 2016
Closed
@patrickhlauke
Copy link
Member Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
accessibility docs v4
Projects
None yet
Milestone
v4.0.0-alpha.3
Development

Successfully merging this pull request may close these issues.
2 participants
@patrickhlauke @mdo