Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduction for using table-reflow. #19408

Merged
merged 1 commit into from
Mar 6, 2016
Merged

Conversation

Pvanhesteren
Copy link
Contributor

This should resolve #18683 (#18683)

@patrickhlauke
Copy link
Member

I'd suggest rewording the first sentence slightly to

Turn traditional tables on their side by using `table-reflow`.

Having thought about it a bit further, I think the impact of people applying this incorrectly is minimal, provided that they do apply it to properly formed data tables (rather than to lay out content, using tables for layout), and only those without any cells spanning multiple rows or columns. So perhaps the last sentence could be removed, and instead add a callout along the lines of

{% callout warning %}
#### Content order and complex tables

Beware that the `table-reflow` style changes the visual order of content. Make sure that you only apply this style to well-formed and simple data tables (and in particular, don't use this for layout tables) with appropriate `<th>` table header cells for each row and column.

In addition, this class will not work correctly for tables with cells that span multiple rows or columns (using `rowspan` or `colspan` attributes).
{% endcallout %}

@Pvanhesteren
Copy link
Contributor Author

@patrickhlauke, thanks for the quick response. I'll make the changes tomorrow! 👍

@florisverburg
Copy link
Contributor

@patrickhlauke, everything is improved according to your suggestions.

@patrickhlauke
Copy link
Member

Lovely. One last request: could you squash this into a single commit?

@florisverburg
Copy link
Contributor

@patrickhlauke, done!

@patrickhlauke patrickhlauke added this to the v4.0.0-alpha.3 milestone Mar 6, 2016
patrickhlauke added a commit that referenced this pull request Mar 6, 2016
Introduction for using table-reflow
@patrickhlauke patrickhlauke merged commit 56b0473 into twbs:v4-dev Mar 6, 2016
@patrickhlauke
Copy link
Member

Perfect, thank you

@mdo mdo mentioned this pull request Mar 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants