Fix running test on iOS with Saucelabs #22464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
Johann-S
force-pushed
the
v4-saucelabs-ios
branch
from
dad08fc to
8bc8072
Compare
|
For me everything is fine here. So if they are someone who think it wasn't the good way please open a PR and /CC me 😉 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we thought our test were runs on iOS 9.3 but due to this bad configuration or maybe a change in Saucelabs it wasn't the case. Our tests were run on Windows 7 Safari 5 😨
It was because of that my branch
v4-experimental-tooltipcannot build correctly (#22444)Thank you @FezVrasta for the idea to check on Angular project 👍
/CC @mdo