Changes popovers from px to rem #23776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresgalante
force-pushed
the
popovers
branch
from
b25b3d4
to
bb1ce01
Compare
This was referenced Aug 31, 2017
mdo
requested changes
Oct 2, 2017
scss/_popover.scss
Outdated
| @@ -5,7 +5,7 @@ | |||
| z-index: $zindex-popover; | |||
| display: block; | |||
| max-width: $popover-max-width; | |||
| padding: $popover-inner-padding; | |||
| // padding: $popover-inner-padding; | |||
scss/_popover.scss
Outdated
| border-top-color: $popover-arrow-outer-color; | ||
| } | ||
|
|
||
| .arrow::after { | ||
| bottom: -($popover-arrow-outer-width - 1); | ||
| margin-left: -($popover-arrow-outer-width - 5); | ||
| bottom: calc((#{$popover-arrow-width} - 1px) * -1); |
There was a problem hiding this comment.
Change the 1px here and elsewhere to $popover-border-width?
|
@andresgalante: I rebased and removed the commented out code. Only thing left is to take care of the other @mdo's comment. |
XhmikosR
reviewed
Oct 9, 2017
scss/_variables.scss
Outdated
| $popover-bg: $white !default; | ||
| $popover-max-width: 276px !default; | ||
| $popover-max-width: 17.5rem !default; |
XhmikosR
reviewed
Oct 9, 2017
|
|
||
| $popover-arrow-width: 10px !default; | ||
| $popover-arrow-height: 5px !default; | ||
| $popover-arrow-width: .8rem !default; |
There was a problem hiding this comment.
@XhmikosR I would say yes for the max-width since we measure grids in px but not for the size of the arrow. But I am not sure, What do you think?
There was a problem hiding this comment.
@XhmikosR actually, if the root font size changes, we want to space of the popover to be larger.
So, maybe the max-width should in rems too, right?
andresgalante
force-pushed
the
popovers
branch
from
8448e28
to
f30dc48
Compare
mdo
approved these changes
Oct 18, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the same idea of #23468 with tooltips, this PR is changing
pxunits toremto meassure popovers.It also nukes the fancy white border as discussed and closes #23763
This is how it looks with shadows turn on: