fix(scrollspy): Spying on nested navs fails to activate for .nav-link's inside nav-item's #23967
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When spying on nested navs, if using the markup where
.nav-link
is inside a.nav-item
,the parent previous sibling was not being highlighted. This PR addresses that issue with two additional lines of code (not including tests):
I discovered this issue when I was finishing porting over ScrollSpy into Boostrap-Vue (via PR bootstrap-vue/bootstrap-vue#1068), and figured I would create a PR on
v4-dev
to fix the official version as well.