#24373 : Documentation/Navbar : Refer to utility classes used. Hidden when printing. #24380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refer to (not navbar) classes used for newbies navbars don't print, so add example of a print-only alternative
typo in {% example %}
add links to component pages
XhmikosR
reviewed
Oct 15, 2017
docs/4.0/components/navbar.md
Outdated
| Here's an example of all the sub-components included in a responsive light-themed navbar that automatically collapses at the `lg` (large) breakpoint. | ||
| Here's an example of all the sub-components. | ||
| - the navbar is light-themed | ||
| - its responsive - it automatically collapses at the `lg` (large) breakpoint. |
I assume id="camelCase" is the standard for id names, rather than the clearly superior id="underscore_words"
mdo
requested changes
Oct 16, 2017
docs/4.0/components/navbar.md
Outdated
| @@ -29,7 +29,10 @@ Navbars come with built-in support for a handful of sub-components. Choose from | |||
| - `.navbar-text` for adding vertically centered strings of text. | |||
| - `.collapse.navbar-collapse` for grouping and hiding navbar contents by a parent breakpoint. | |||
|
|
|||
| Here's an example of all the sub-components included in a responsive light-themed navbar that automatically collapses at the `lg` (large) breakpoint. | |||
| Here's an example of all the sub-components. | |||
docs/4.0/components/navbar.md
Outdated
| @@ -536,3 +550,16 @@ Sometimes you want to use the collapse plugin to trigger hidden content elsewher | |||
| </nav> | |||
| </div> | |||
| {% endexample %} | |||
|
|
|||
| ## Printing | |||
There was a problem hiding this comment.
This should also be a note in the how it works section. The rest of this isn't relevant to the navbar itself and can be covered by the display utilities docs.
Navbars are hidden by default when printing. Force them to be printed by adding
.d-printto the.navbar.
still like to emphasise the foreign utility classes in the main example bg-light's name is self explanatory (so its obvious where to look it up), but mr-sm-2's name isn't at first
aavmurphy
changed the title
... as they are position:fixed. better wording welcome
|
@mdo please re-check. have added 1 more thing (fixed-top/bottom uses position:fixed), so doesn't reserve a gap on the screen. couldn't thing of a nice way to phrase it though. thanks |
- rewrite utils line and link to the utils pages - restore the paragraphs to the placement section - fix formatting and grammar
mdo
approved these changes
Oct 18, 2017
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refer to the (not navbar) classes used for newbies
add: navbars don't print
give the 1st example a drop-down (as its the template people will copy and adapt)