Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for right padding in dismissible alerts #24481

Merged
merged 4 commits into from
Oct 22, 2017
Merged

Conversation

Kopyov
Copy link
Contributor

@Kopyov Kopyov commented Oct 20, 2017

Added right padding to dismissible alerts to avoid button/text overlap.

Fixes #24469

scss/_alert.scss Outdated
@@ -27,6 +27,8 @@
// Expand the right padding and account for the close button's positioning.

.alert-dismissible {
padding-right: ($close-font-size + $alert-padding-x);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unexpected whitespace at end of line no-eol-whitespace

Copy link
Collaborator

@andresgalante andresgalante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good solution. There is more information on whats the result of this PR here #24469

Thanks @Kopyov

@mdo mdo merged commit 0a82cd9 into twbs:v4-dev Oct 22, 2017
@mdo mdo mentioned this pull request Oct 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants