Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure our plugins can work in jQuery.noConflict mode #24530

Merged
merged 1 commit into from
Oct 24, 2017

Conversation

Johann-S
Copy link
Member

@Johann-S Johann-S commented Oct 24, 2017

Fixes : #24527

@nextgenthemes can you confirm it works as wanted ?
See my CodePen which use my last changes and jQuery used by Wordpress : https://codepen.io/Johann-S/pen/PJvrgj

@nextgenthemes
Copy link
Contributor

nextgenthemes commented Oct 24, 2017

Thanks, this finally did it! Tested it here.

It would be helpful if fresh changes like this on separate branches would be build to the dist/ dir. Then people could use rawgit to include those versions onto their JSbins codepens ... (JSBin even refuses "to big" if I not use the minified version). Also the need to copy paste them is probably error prone and there is no clear indication what version is used exactly (on the Bins).

I guess you do not do this because thats not wanted in the PRs and you only build when the next version is ready? Maybe some automation for this? Just a Idea.

@Johann-S
Copy link
Member Author

Johann-S commented Oct 24, 2017

When they are a lot of changes @mdo do a build commit and it happens several times before our next release 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants