Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add responsive variations for sizing #24623

Closed
wants to merge 1 commit into from

Conversation

XavRsl
Copy link

@XavRsl XavRsl commented Oct 31, 2017

Hi,

With this kind of code:

<div class="card-body">
    <h2 class="card-title font-weight-light">Dashboard Features</h2>
    <div class="row mx-auto py-3">
        <div class="col-sm">
            <h3>Email alerts</h3>
            <p>Get an email everytime a new comment appears on one of your journal's publications.</p>
        </div>
        <div class="col-sm">
            <h3>Journal dedicated recent comments</h3>
            <p>The dashboard holds a list of the most recent comments on your journal's publications.</p>
        </div>
        <div class="col-sm">
            <h3>Invite colleagues to your journal's dashboard</h3>
            <p>You may invite collaborators to your dashboard  who can also choose to be alerted to new comments on your journal.</p>
        </div>
        <div class="col-sm">
            <h3>Journal dedicated search</h3>
            <p>Search through all your journal's publications comments for authors, commenters, comments' content, …</p>
        </div>
        <div class="col-sm">
            <h3>Number of commented publications</h3>
            <p>Get the number of your journal's commented publications.</p>
        </div>
    </div>
    <div class="row mx-auto w-lg-75 py-3">
        <div class="col-sm">
            <h3>Certified Journal response</h3>
            <p>Leave official Journal responses on PubPeer.</p>
        </div>
        <div class="col-sm">
            <h3>Acknowledge comments</h3>
            <p>Let PubPeer users know that your journal has seen a comments.</p>
        </div>
        <div class="col-sm">
            <h3>Free trial period</h3>
            <p>Try out Journal Dashboard for free.</p>
        </div>
        <div class="col-sm">
            <h3>PubPeer statistics</h3>
            <p>Access stats such as the number of page views for each PubPeer thread.</p>
        </div>
    </div>
</div>

My page looks like this on large:

capture d ecran 2017-10-31 a 15 28 20

And will look like this on smaller screen:

capture d ecran 2017-10-31 a 15 28 32

Would that be a good idea for Bootstrap?

Thanks for your attention.

Xavier

@gijsbotje
Copy link
Contributor

i think you can allready achieve this with flex utilities and the grid classes

@XavRsl
Copy link
Author

XavRsl commented Oct 31, 2017

I didn't really find any way to achieve this without css grids. This method seemed elegant and close enough to the Bootstrap v4's spirit... 😋

@XhmikosR XhmikosR requested a review from mdo October 31, 2017 16:51
@andresgalante
Copy link
Collaborator

Hi @XavRsl Thanks a lot for your PR.

This has been done in this PR #24015 and close with this comment.

I'll leave it open in case @mdo wants to reconsider this idea.

@mdo
Copy link
Member

mdo commented Oct 31, 2017

Yup, closing still :). Thanks though!

@mdo mdo closed this Oct 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants