Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set cursor:pointer for <summary> #24630

Merged
merged 3 commits into from
Dec 28, 2017

Conversation

andresgalante
Copy link
Collaborator

This PR changes the cursor to pointer on the docs.

@mdo I wonder if this belongs to reboot.

closes #24617

@mdo
Copy link
Member

mdo commented Nov 1, 2017

I wonder if this belongs to reboot.

Given it's an element, let's put it in Reboot. If it was a .class, it'd be something to reset elsewhere :). Let's also add a note to the Reboot docs to explain that we make this change.

@andresgalante andresgalante force-pushed the v4-dev-andres-fix-pointer-on-docs branch 2 times, most recently from ef51310 to ba85a5e Compare November 1, 2017 13:42
@andresgalante andresgalante force-pushed the v4-dev-andres-fix-pointer-on-docs branch from ba85a5e to f138588 Compare November 1, 2017 13:43
@andresgalante andresgalante changed the title Changes the cursor of the summary element on the docs Changes the cursor of the summary element Nov 1, 2017
@andresgalante
Copy link
Collaborator Author

Before we merge it, lets consider this: I found out why the cursor is text and not pointer:

If you have an anchor inside the summary, then the anchor will have a pointer:
https://codepen.io/pen/?editors=1010

@XhmikosR
Copy link
Member

XhmikosR commented Nov 1, 2017

How about we just use our collapse?

@patrickhlauke
Copy link
Member

Before we merge it, lets consider this: I found out why the cursor is text and not pointer:
If you have an anchor inside the summary, then the anchor will have a pointer

it's a pretty bad UI/UX decision at the moment in browsers. and as anchors/links in the summary would still be styled like normal links, it's not really problematic i'd say.

@patrickhlauke patrickhlauke merged commit a5232ab into v4-dev Dec 28, 2017
@patrickhlauke patrickhlauke changed the title Changes the cursor of the summary element Set cursor:pointer for <summary> Dec 28, 2017
@mdo mdo mentioned this pull request Dec 28, 2017
@patrickhlauke
Copy link
Member

sorry @mdo, didn't notice the v4-stable project. have i messed up the release plan?

@mdo mdo deleted the v4-dev-andres-fix-pointer-on-docs branch December 28, 2017 05:06
@mdo
Copy link
Member

mdo commented Dec 28, 2017

@patrickhlauke Nope, just trying to budget out issues and PRs :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants